fix(caps-warning): caps state isn't always correct (@Leonabcd123, @fehmer)#7478
Merged
Miodec merged 45 commits intomonkeytypegame:masterfrom Feb 27, 2026
Merged
fix(caps-warning): caps state isn't always correct (@Leonabcd123, @fehmer)#7478Miodec merged 45 commits intomonkeytypegame:masterfrom
Miodec merged 45 commits intomonkeytypegame:masterfrom
Conversation
Leonabcd123
changed the title
|
This works, but it does reintroduce internal inversion for Linux CapsLock events. Conceptually, the issue on Linux is timing (modifier state not settled at event time), not that getModifierState("CapsLock") is incorrect. A deferred read would avoid platform-specific inversion and keep CapsLock state fully derived from OS state. Might be worth considering if we want to avoid encoding Linux timing assumptions into logic long-term. |
This reverts commit f29ffd4.
22 tasks
Leonabcd123
force-pushed
the
fix-caps-warning
branch
from
7d5eeba to
744609c
Compare
Leonabcd123
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Account for platform specific behavior.
Fixes #7472